[Security Solution] enable CPS picker in read only mode for all Security Solution pages#264816
Conversation
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
rylnd
left a comment
There was a problem hiding this comment.
LGTM, just had a quick question about how the usage of the client picker relates to these changes.
f69b004 to
4a4add2
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
4a4add2 to
7ac7e80
Compare
maximpn
left a comment
There was a problem hiding this comment.
The changes LGTM. I've tested them locally and it works as expected.
7ac7e80 to
f64331b
Compare
|
Hey @PhilippeOberti, thanks for this wanted to clarify a workflow. I have a related open PR (#267895) that enables the picker in EDITABLE mode specifically on Explore pages (Hosts, Users, Network, entity detail views), and DISABLED everywhere else. Your approach is READ_ONLY across all Security Solution pages, which is broader. These two will conflict in A few questions :
cc @jaredburgett |
@abhishekbhatia1710 how recent is your information? Over the last couple of weeks I've attended a few CPS related meetings and it was always mentioned that the goal is to have it READONLY on all Security pages. I have never heard that some pages would be EDITABLE. If that's what we truly want, then for sure we need to ensure that by default all pages should be READONLY, and only override that to EDITABLE for some pages. I'll check with product today and will report back (@paulewing) |
Thanks for the context @PhilippeOberti ,I have only recently been introduced to the CPS space and wasn't part of those meetings, so I wasn't aware that |
f64331b to
999f137
Compare
kfirpeled
left a comment
There was a problem hiding this comment.
@PhilippeOberti not sure if the attached screenshot is up to date.
But when in READ-ONLY, I find the text: You can adjust it for your space, or override it for individual queries inaccurate.
As far as I know, we don't allow in the security solution to override it for individual queries.
Thanks for the review @kfirpeled. We don't own nor control what's shown in the picker itself. We can just drive its state, so I'm not sure about it's content... If I had to guess, it was meant for things like ESQL in Discover or Timeline, where a user can indeed override for a specific query. |
Thanks for the review @ashokaditya . We don't own nor control what's shown in the picker itself. We can just drive its state, so I'm not sure about it's content... |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|

Summary
This PR enables the CPS picker in read only mode for all Security Solution pages by default.
How to test
Follow the steps here to test locally.
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.